CMSC 23700
Introduction to Computer Graphics

Project 3 errata

• The View->spotLightDir vector is not being initialized. Lines 78-81 of view.c should be:

      View->spotLightPos[0]       = 0.0;
      View->spotLightPos[1]       = 1.5;
      View->spotLightPos[2]       = 0.0;
      View->spotLightPos[3]       = 1.0;
      

• In view.h, there is a conflict between the #define of the symbols DIR_LIGHT and SPOT_LIGHT in view.h, and their definition in the LightMode_t enumeration type. I recommend that you change the names of the #define symbols, which are defined on lines 63-64 of view.h and used on lines 138-149 of view.c.

• The shader functions dirLighting and spotLighting in shaders/shader.frag have their names swapped.

• The switch statement in EnableLights (view.c) should be as follows:

     switch (View->lighting) {
       case DIR_LIGHT: // directional lighting
          glUniform1i (enableDirLightLoc, GL_TRUE);
          glUniform1i (enableSpotLightLoc, GL_FALSE);
          break;
       case SPOT_LIGHT: // spot lighting
          glUniform1i (enableDirLightLoc, GL_FALSE);
          glUniform1i (enableSpotLightLoc, GL_TRUE);
          break;
       case BOTH_LIGHTS: // use both lights
          glUniform1i (enableDirLightLoc, GL_TRUE);
          glUniform1i (enableSpotLightLoc, GL_TRUE);
          break;
       default:
          assert (0);
     }
  

• In MultMV3f (matrix.h), the body of the loop should be

  dst[i] = mat[0+i] * v[0] + mat[3+i] * v[1] + mat[6+i] * v[2];